DataGrid: group and total summary overlapping #32211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes overlapping issues between group rows and total summary in DataGrid by adjusting background-color properties for sticky columns across all themes.
Changes:
- Changed
background-color: transparenttobackground-color: inheritfor sticky columns in group rows across all three themes (material, generic, fluent) - Inverted the CSS selector logic in the base gridBase file for total footer to apply
background-color: transparentto non-sticky columns instead of sticky columns
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/material/dataGrid/_index.scss | Changed sticky group cell background from transparent to inherit |
| packages/devextreme-scss/scss/widgets/generic/dataGrid/_index.scss | Changed sticky group cell background from transparent to inherit |
| packages/devextreme-scss/scss/widgets/fluent/dataGrid/_index.scss | Changed sticky group cell background from transparent to inherit |
| packages/devextreme-scss/scss/widgets/base/_gridBase.scss | Inverted selector to apply transparent background to non-sticky columns in total footer |
dmirgaev
force-pushed
the
26_1__T1284612_summary
branch
from
9bd12d2 to
101dd1e
Compare
dmirgaev
force-pushed
the
26_1__T1284612_summary
branch
from
101dd1e to
ba19bc5
Compare
dmirgaev
force-pushed
the
26_1__T1284612_summary
branch
from
ba19bc5 to
fb44f69
Compare
dmirgaev
force-pushed
the
26_1__T1284612_summary
branch
from
d7a7b63 to
5421d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.